Loader
logo

Wrong gender checks remain

Started by tos1, March 02, 2023, 10:19:44 AM

Previous topic - Next topic
March 02, 2023, 10:19:44 AM Last Edit: March 19, 2023, 01:07:56 PM by tos1
At least the line below is wrong as far as I checked.

----
dlga_freed_lord_answer_2:close_window ---> "sire" is displayed for female player char. (I actually tested.)
Thank you, good {sire/lady}. I never forget someone who's done me a good turn.
----

The line below seems to have no problem (if it is of a companion who became a lord). (*1)
----
dlga_freed_hero_answer_2:close_window
Thank you, good {sire/lady}. I never forget someone who's done me a good turn.
----

*1  I believe the "hero" here means a companion who became a lord. I actually tested to rescue a captured lord companion (Lord Xhondo) using a female player character, and "lady"  was displayed properly. If the line is not of lord companion, then please check the appropriateness of the line.

- How to reproduce it/when/why it happens:
Play as a female character (I tested without belonging to any faction), rescue captured lord of a faction from a castle (I rescued a male lord). He wrongly says the sentence "Thank you, good sire. I..." to the female player char.

In order to check companion's case, play as a female character without belonging to any faction, capture at least one castle (to become a Queen), let a companion hold a fief (village). She/he becomes a lord. Order the lord companion to accompany, guide her/him to area where many enemy troops are. When the enemy troops attack the lord companion, abandon her/him and wait till she/he is captured. After a few days, search and find the location of the captured lord companion (e.g. from castles of the enemy lord who attacked the lord companion). Approach to the castle, check the lord companion exists as a prisoner by hovering mouse over the castle, sneak into it, rescue her/him. She/he properly says the sentence "Thank you, good lady. I..." to the female player char.

- Game version (and steam or downloaded):
AWoIaF v8.2, Warband v1.174 downloaded


--------------------------------------
Edited to add another on Mar 5 2023 UTC:

Missing gender check of the lord and player character in the raven message order window.

----
qstr_>>Diplomacy:^It_is_o
>>Diplomacy:^It is only possible to negotiate between faction leaders.^You aren't a king.
----
qstr_>>Diplomacy:^It_is_on
>>Diplomacy:^It is only possible to negotiate between faction leaders.^{s1} isn't a king.
----

I guess it's necessary to check each gender of the player character (using reg59) and the lord (using what register?) or to replace "king" with e.g. "such person".

- How to reproduce it/when/why it happens:
Visit the lord's hall of several castles, find a maester, talk to him, select "Do you have any ravens? I need to send a message.", select any Lady from choices, and left-click twice. The message order window appears. See the bottom of left side; "Lady xxxx isn't a king."

- Game version (and steam or downloaded):
AWoIaF v8.2, Warband v1.174 downloaded


--------------------------------------
Edited to add on Mar 18 2023 UTC:

Missing gender check for the lord/lady as emissary's destination.

(1) The sentence by a companion minister below includes a static "him".

----
dlga_minister_diplomatic_initiative_type:minister_diplomatic_initiative_type_select
What do you wish to tell him?
----

(2) The choices below include static 2 "him" and 2 "his".

---- 3rd choice
dlga_minister_diplomatic_initiative_type_select:minister_diplomatic_emissary.4
Tell {s10} that I want to conclude a non-aggression treaty with him.
---- 4th choice
dlga_minister_diplomatic_initiative_type_select:minister_diplomatic_emissary.7
That I wish to put myself under his protection, as his vassal.
---- 6th choice
dlga_minister_diplomatic_initiative_type_select:minister_declare_war
That I declare war upon him.
----

These 4 lines must check the gender of the lord/lady selected at the prior choice by the player.

- How to reproduce it/when/why it happens:
Play as an independent faction, capture a castle, and hire a minister. Replace the minister with a companion, exit from the hall, and re-enter. Talk to the companion minister, select "I wish to dispatch an emissary.". The companion minister asks you "To whom do you wish to send this emissary?". Select any female character from the choices. The companion minister says "...him?" above and the third , fourth, and sixth choice include one or two static "him" or "his".

- Game version (and steam or downloaded):
AWoIaF v8.2, Warband v1.174 downloaded

--------------------------------------
Edited to add on Mar 19 2023 UTC:

The line below includes static "He" and "him".

----
str_lord_indicted_player_faction
By order of {s6}, {s4} of the {s5} has been indicted for treason. The lord has been stripped of all {reg4?her:his} properties, and has fled for {reg4?her:his} life. He wishes to join your kingdom. You may find him in your court, if you wish it.
----

- Game version (and steam or downloaded):
AWoIaF v8.2, Warband v1.174 downloaded

Quick Reply

Note: this post will not display until it has been approved by a moderator.

Name:
Email:
Shortcuts: ALT+S post or ALT+P preview